[SPARK-38681][SQL] Support nested generic case classes #36004
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eejbyfeldt
changed the title
|
Can one of the admins verify this patch? |
eejbyfeldt
force-pushed
the
SPARK-38681-nested-generic
branch
from
a74f6d6 to
4b418ec
Compare
Contributor
Author
|
While testing the spark 3.3.0 release candidate I noticed that this is actually a regression from 3.2 that was introduced in #33205 so I this should also be fixed in the 3.3 branch. |
cloud-fan
approved these changes
May 19, 2022
Member
|
Thank you, @eejbyfeldt . cc @srowen |
srowen
approved these changes
May 19, 2022
Member
|
Merged to master/3.3 |
srowen
pushed a commit
that referenced
this pull request
May 20, 2022
### What changes were proposed in this pull request? Master and branch-3.3 will fail to derive schema for case classes with generic parameters if the parameter was not used directly as a field, but instead pass on as a generic parameter to another type. e.g. ``` case class NestedGeneric[T]( generic: GenericData[T]) ``` This is a regression from the latest release of 3.2.1 where this works as expected. ### Why are the changes needed? Support more general case classes that user might have. ### Does this PR introduce _any_ user-facing change? Better support for generic case classes. ### How was this patch tested? New specs in ScalaReflectionSuite and ExpressionEncoderSuite. All the new test cases that does not use value classes pass if added to the 3.2 branch Closes #36004 from eejbyfeldt/SPARK-38681-nested-generic. Authored-by: Emil Ejbyfeldt <[email protected]> Signed-off-by: Sean Owen <[email protected]> (cherry picked from commit 49c6802) Signed-off-by: Sean Owen <[email protected]>
Member
|
Thank you, @eejbyfeldt , @cloud-fan , @srowen ! cc @MaxGekk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Master and branch-3.3 will fail to derive schema for case classes with generic parameters if the parameter was not used directly as a field, but instead pass on as a generic parameter to another type. e.g.
This is a regression from the latest release of 3.2.1 where this works as expected.
Why are the changes needed?
Support more general case classes that user might have.
Does this PR introduce any user-facing change?
Better support for generic case classes.
How was this patch tested?
New specs in ScalaReflectionSuite and ExpressionEncoderSuite. All the new test cases that does not use value classes pass if added to the 3.2 branch